Ansisilon 2077 info module #117
Open
+98
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kritika-Bhateja-03
requested review from
Bhavneet-Sharma,
meenakshidembi691 and
trisha-dell
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 81.90% 82.98% +1.08%
==========================================
Files 124 133 +9
Lines 13463 14538 +1075
Branches 1989 2139 +150
==========================================
+ Hits 11027 12065 +1038
+ Misses 1830 1828 -2
- Partials 606 645 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sachin-apa
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Can we update the documentation with the following.
- Call out that smb files would return for all the clusters for this fact.
- It is assumed that credentials of all node is same as the I(hostname). if not only the smb files of the nodes that has same credentials will be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration